Dev windows support part2 #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loongs-zhang
force-pushed
the
dev-windows-support-part2
branch
from
98d89f1 to
b124657
Compare
loongs-zhang
force-pushed
the
dev-windows-support-part2
branch
from
22be20a to
4a4a2c4
Compare
ihciah
reviewed
Feb 21, 2024
monoio/src/driver/legacy/mod.rs
Outdated
| #[cfg(windows)] | ||
| poll: iocp::Poller, | ||
| poll: Poller, |
There was a problem hiding this comment.
I have 2 questions:
- Which way do you want to iocp? It can be used as epoll to just get notified if the fd is ready, it can also be used like iouring to let it do io directly.
- If it is designed to work as a readiness poller, can we use
mio::Pollinstead of brings a new poller impl?
There was a problem hiding this comment.
- Which way do you want to iocp? It can be used as epoll to just get notified if the fd is ready, it can also be used like iouring to let it do io directly.
Just epoll.
- If it is designed to work as a readiness poller, can we use
mio::Pollinstead of brings a new poller impl?
No, cause #166 (comment)
loongs-zhang
force-pushed
the
dev-windows-support-part2
branch
2 times, most recently
from
0b98ba3 to
52ff11b
Compare
loongs-zhang
force-pushed
the
dev-windows-support-part2
branch
from
52ff11b to
f1182e6
Compare
loongs-zhang
force-pushed
the
dev-windows-support-part2
branch
from
27bbfd3 to
f1182e6
Compare
|
It seems that due to caching, windows CI is unstable, see https://github.com/loongs-zhang/monoio/actions/runs/8005626446/job/21865508898 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly uses polling as the
LegacyDriver, as you can see, it can be successfully compiled and run a small number of tests.Plan to pass really all windows CI in the next PR.